Skip to content

Pin huggingface_hub in more places #15403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

Pin huggingface_hub in more places #15403

merged 1 commit into from
Oct 27, 2025

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Oct 27, 2025 •
edited
Loading

Summary

We need to pin huggingface_hub in CI to avoid an incompatibility with our pinned version of transformers. See #15399 for more context - I missed a few places on trunk jobs. Cleaning these up here.

Test Plan

Running with ciflow/trunk. I verified that the test-huggingface-transformers-macos / * and gemma3-4b macos jobs pass on this PR. They are failing on trunk (see https://hud.pytorch.org/pytorch/executorch/commit/4c30da308ee811bdfa44fd4bea3bc439bfd303d4 for an example).

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15403

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 6 Cancelled Jobs, 129 Pending

As of commit 20449cc with merge base 57f0dfd (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@GregoryComer GregoryComer marked this pull request as ready for review October 27, 2025 22:37
@GregoryComer GregoryComer merged commit 72b1fa1 into pytorch:main Oct 27, 2025
293 of 308 checks passed
@GregoryComer GregoryComer mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GregoryComer @SS-JIA